search

aviau / python-pass

For fun - I have decided to write pass in python
http://aviau.github.io/python-pass/
GNU General Public License v3.0
36 stars 17 forks source link

Create subdirectories if specified in password path #14

Closed mdellweg closed 6 years ago

mdellweg commented 6 years ago

This patch allows to specify password entries in subdirectories. If the directory does not exist, it will be created before invoking gnupg.

aviau commented 6 years ago

Will take a look soon! Thanks for the pr :)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 90.68% when pulling af7a506d9281667e438d1d6e7e4504a9fe101b6d on mdellweg:create_subdirs_if_needed into 7f97083862ceac402fe08f9eed29b428832ce230 on aviau:master.

aviau commented 6 years ago

Can you assert that the directory does not exist before?

Sorry for the slow reviews! I'll try to review faster.

mdellweg commented 6 years ago

Do you mean before creating the path, or in the tests?

aviau commented 6 years ago

in the tests.

mdellweg commented 6 years ago

Now that travis seems to be functional again, can you restart the test? I'm sure, it passes ;)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 90.698% when pulling ea3c11da22511ab30d1939bd55381bda116225fb on mdellweg:create_subdirs_if_needed into 7f97083862ceac402fe08f9eed29b428832ce230 on aviau:master.

mdellweg commented 6 years ago

Thank you! Very nice project btw!