search

aviau / python-pass

For fun - I have decided to write pass in python
http://aviau.github.io/python-pass/
GNU General Public License v3.0
36 stars 17 forks source link

Support .gpg_id files in subdirectories #25

Closed TheLastProject closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.1%) to 92.136% when pulling a94c053e4484f46218b1a8c87efbb2f80ec2d7aa on TheLastProject:feature/support_sub_gpg_ids into c86fd551f2b3da5369f3c178eb3feaa9a07d9149 on aviau:master.

TheLastProject commented 4 years ago

I should've written a description.

Basically, this will look for a .gpg-id file until it can find one and then use that, throwing an exception if none is found. This means that if you put a .gpg-id in a "Work" directory, that and every subdirectory will use that .gpg-id instead of your main .gpg-id (with the exception of any of those subdirectories which may have their own .gpg-id). I believe this is how it works with upstream pass as well.

aviau commented 4 years ago

Good work! I have made small comments before we merge but this looks good.

TheLastProject commented 4 years ago

Tell me if there's anything more to be done :)

aviau commented 4 years ago

Clean, simple code.

LGTM!

aviau commented 4 years ago

Thanks for your work @TheLastProject !