Adds Parser for header fields to support header values containing colons

aviaviavi / curl-runnings

A declarative test framework for quickly and easily writing integration tests against JSON APIs.

MIT License

158 stars 13 forks source link

Adds Parser for header fields to support header values containing colons #46

Closed paulcadman closed 4 years ago

paulcadman commented 4 years ago

I've found curl-runnings very useful in a recent project. I had to make a few modifications that I'm going to contribute back.

Firstly, I needed the specs to have support for header values that contain colons (e.g "key: a:b:c"). This PR adds support for this use-case by adding a Parser for Headers.

aviaviavi commented 4 years ago

Thanks so much for your contribution Paul! Glad the project has been useful to you. I'll have some time to look this over within the next few days.

aviaviavi commented 4 years ago

This looks great, thanks again @paulcadman. From your initial comment I couldn't tell if you're planning to open other PR's as well? If so, I'll wait for those before I cut a new release of curl-runnings. Let me know!

paulcadman commented 4 years ago

hi @aviaviavi thanks for the merge - I have a few PRs in the pipeline:

URLEncoded request bodies
Specifying query parameters as an object in the spec (with interpolation)
Client certificate authentication

Also I have implemented JWT signing - but that one relies on a fix I need to make to the upstream jwt library so that can probably wait. I'm having trouble figuring out how to submit it.

aviaviavi commented 4 years ago

Awesome! I'll hold off on the release for now.