search

aviaviavi / toodles

Project management directly from the TODOs in your codebase
MIT License
968 stars 35 forks source link

WIP Multi-stage Dockerfile #46

Closed tln closed 5 years ago

tln commented 5 years ago

This builds and runs the binary which then says 'Something went wrong' Probably the assets are missing?

Re: issue #11

aviaviavi commented 5 years ago

Yeah probably assets are missing, and the haskell code relies on cabal a bit currently to know where to look for them.

I actually made a change to the haskell code for my WIP branch for this issue - https://github.com/aviaviavi/toodles/compare/minimal-docker?expand=1. But also now that there is #47 this already might be solved? Still waiting to try to it out.

aviaviavi commented 5 years ago

Also thanks so much for the first contribution @tln! Sorry that it seems like we have multiple attempts going on this at once. I'm still ironing out the coordination aspect of this project :)

tln commented 5 years ago

No problem! I tried out #47, it worked for me, so that solves this issue

On Sat, Nov 3, 2018 at 3:19 PM Avi Press notifications@github.com wrote:

Also thanks so much for the first contribution @tln https://github.com/tln! Sorry that it seems like we have multiple attempts going on this at once. I'm still ironing out the coordination aspect of this project :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aviaviavi/toodles/pull/46#issuecomment-435625335, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjQUEbfuddei-_v5SA5gZCpwFatb8jJks5urhZrgaJpZM4YM-1B .