search

avibrazil / RDM

Easily set Mac Retina display to higher unsupported resolutions
4.12k stars 353 forks source link

Better icon support #4

Open aryamccarthy opened 7 years ago

aryamccarthy commented 7 years ago

Improved handling of Dark Mode and appearance of About Pane on Retina displays, adding HiDPI support.

avibrazil commented 7 years ago

@aryamccarthy I'd like to accept this but I'm not very fluent with Git. Would you please break this pull request into 3? I think the "unused" images need a different approach which is to not package it in the installable binary, but big image must remain there in the source.

Or please would you be kind and let me know the commands I need to issue to accept 1c7284d and a4bccb2.

Thank you in advance

avibrazil commented 7 years ago

I accepted most of it with git-cherry-pick. But I don't know how to make the fork graph reflect the changes. Your commits appear here: https://github.com/avibrazil/RDM/commits/master

Thank you !

aryamccarthy commented 7 years ago

Thanks for working through this.

Since you've cherry-picked the majority of my changes, the best way to reflect this in the fork graph is for me to commit again, undoing the changes you've already pulled, then having you accept my pull request.

aryamccarthy commented 7 years ago

Everything looks good to go, @avibrazil. Let me know if you have any other concerns; otherwise, I think the branch is ready to pull.

aryamccarthy commented 7 years ago

Is there anything else left to do before this branch is merged?

avibrazil commented 7 years ago

Hello @aryamccarthy

I'm sorry, I still don't know what to do with this, don't know how to merge. Apparently there are still icons being deleted in the patch.

aryamccarthy commented 7 years ago

You're right, but they're all unused anyway. Github says there are no conflicts. You should be able to accept my pull request from this page.

razzkazz commented 6 years ago

Hi, not sure if this is correct place to post. I started using RDM as I was doing screen recording and needed 1920x1080. When I sent a test video to the video editor he replied saying "Seems like with this app there is no anti aliasing and because of that text looks over sharpened, can you check if there is an option to turn anti-aliasing on?" This is beyond me, I am an audio guy. Is it true what he says? I have attached a test video. RDM app test.mp4.zip

avibrazil commented 6 years ago

razzkazz, apparently your display is not HiDPI when set to 1980x1080. This reduces the pixel density and small texts will indeed suffer with terrible effects. Anti-aliasing is a text rendering technique that reduces this ugly effects. I think modern Macs don't have settings for that because its not needed on retina displays. Unless you turn off HiDPI, which is exactly what you are doing when going 1920x1080.

On the other hand, if you manage to capture on HiDPI resolutions, your resulting video will be huge and not useful.

I don't know what to tell you. Screencasting is a challenge, specially with screen-busy applications as the one you are using. Macs have accessibility settings that will let you zoom parts of the screen with Command+Option+plus and minus. Enable that to highlight parts of the screen you want to show during your recordings.

razzkazz commented 6 years ago

Thanks for getting back to me. Ok that all makes sense and clears it up for me. I do use zoom functions. File size is less of an issue (within reason), quality is the main priority.