search

avidofood / vue-responsive-video-background-player

Play your own videos in background responsively in different resolutions.
https://avidofood.github.io/vue-responsive-video-background-player/
MIT License
292 stars 36 forks source link

IE 11 and Edge issues #1

Closed nawalnew closed 4 years ago

nawalnew commented 4 years ago

Hello,

I have a urgent Problem.

The Video is not even Playing on all IE Browsers!

Is there a workaround for that?

Thank you.

nawalnew commented 4 years ago

I found the Bug,

its "object-fit"

But to get it to work,I need to add: "data-object-fit="cover"". to the video element somehow.

Any Idea? Than it should work

pmochine commented 4 years ago

@nawalnew Oh sorry, I didn't get any mails and just saw the issue. I will try and have a look.

pmochine commented 4 years ago

Ok. I guess you want me to add data-object, so you can use this? https://github.com/constancecchen/object-fit-polyfill

I try to implement this.

pmochine commented 4 years ago

@nawalnew I need your help, I can't fix it because I don't have IE or Edge...

Could you have alook at : https://pmochine.github.io/delete-me-soon/

What's wrong there?

nawalnew commented 4 years ago

Hey @pmochine,

im Sorry fir the late reply.

Your code works beautiful. i had just a stupid problem ( have it still ) --> If I try to view a Website in IE on my Virtual Machine ( Parallels ), than it isnt showed. But thats a Problem with Parallels!

So the first Problem that the Video isnt showed is solved by doing the tzests on a real Windows Machine.

To the Second problem: Polyfills :)

Ive fixed it with https://github.com/constancecchen/object-fit-polyfill and your script works like a charm. Ive Implemented data-object-fit vie VueJS on the Compinent. and it works everithing fine now.

im so sorry for your time with Troubleshooting.

Thank you for your awesome help and your awesome Vue Component. it solves a lot of Problems and works nice!

pmochine commented 4 years ago

@nawalnew Ok as I understood it correctly, you have fixed it by adding object-fit-polyfill manually right? So I don't have to change the code?

Thank you for your kind words! I'll close the issue then, ok?