search

avidofood / vue-responsive-video-background-player

Play your own videos in background responsively in different resolutions.
https://avidofood.github.io/vue-responsive-video-background-player/
MIT License
292 stars 36 forks source link

Warnings with Vue3 #20

Closed guyromb closed 3 years ago

guyromb commented 3 years ago

I see 3 warnings in the console when using Vue 3.0.3 (with vue-responsive-video-background-player 2.0.0)

runtime-core.esm-bundler.js?5c40:38 [Vue warn]: `beforeDestroy` has been renamed to `beforeUnmount`. 
  at <VideoBackground src="img/videoplayback-2.mp4" > 
  at <Main onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< undefined > > 
  at <RouterView key="/main" > 
  at <TheContainer onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< undefined > > 
  at <RouterView> 
  at <App>
Component emitted event "ready" but it is neither declared in the emits option nor as an "onReady" prop.
Component emitted event "playing" but it is neither declared in the emits option nor as an "onPlaying" prop.

I believe we have missing emits in the component, and "beforeDestroy" has to be renamed to "beforeUnmount".

pmochine commented 3 years ago

@guyromb thanks! It's weird that I didn't get the warnings. Could you please download the latest version and have a look? In the mean time I'm going to close this now