Fixed the _tasks variable assignment

avidraghav / MyNotes

📝 A demo todo/notes app which demonstrates the use of MVVM architecture with Test-cases, Navigation Component Library, Room Database, LiveData, Coroutines, Datastore etc.

Apache License 2.0

126 stars 26 forks source link

Fixed the _tasks variable assignment #5

Closed ravi-kumar7 closed 2 years ago

ravi-kumar7 commented 2 years ago

Fixes #4

Changelog:

Removed unnecessary assignment
Updated code to use postValue(). As it works in background thread and is safer for IO tasks.

avidraghav commented 2 years ago

the major use case of postValue() is when we are assigning the values to livedata from a background thread. Currently the values are being assigned from UI thread itself hence it will not a make a difference. Thanks for the contribution 🙂

avidraghav commented 2 years ago

Congratulations 🎉 your PR has been merged, thanks for contributing to MyNotes. Do share this milestone on social media! 🙂