search

aviflombaum / shadcn-rails

https://shadcn.rails-components.com
MIT License
470 stars 32 forks source link

Eerkmen/fix/unclosed script tags: Fix unclosed script tags in _filter.html.erb and _list.html.erb partials #66

Open eerkmen opened 1 month ago

eerkmen commented 1 month ago

Summary

This pull request addresses the issue #65 . Ensuring proper closure of these tags is crucial for maintaining a well-structured HTML and preventing potential rendering issues.

Changes Made

  1. _filter.html.erb:

    • Ensured all tags are properly closed to prevent rendering issues.
    • Improved HTML structure for better readability and maintenance.

  2. _list.html.erb:

    • Corrected the closure of tags to ensure proper HTML structure.
    • Enhanced code readability by ensuring proper tag closure.

Problem Description

The unclosed script tags in the _filter.html.erb and _list.html.erb partials caused rendering issues, leading to improper UI behavior and potential bugs. Proper closure of these tags is essential for the correct functioning of the UI components that rely on these partials.

Testing

  1. Scenario: Load the components using the _filter.html.erb and _list.html.erb partials.

    • Expected Result: The components should render correctly without any HTML structure issues.
    • Verification: Ensure that all elements are properly displayed and functioning as expected.

  2. Scenario: Verify the overall functionality of the filter and list components.

    • Expected Result: The components should behave as intended, with no script execution issues.
    • Verification: Confirm that the components perform their respective actions correctly.

Additional Information

These changes ensure that the HTML structure is well-formed, preventing potential rendering and script execution issues. Please review and merge this pull request to apply the fixes.