add r.min/r.max command

aviggiano / redis-roaring

Roaring Bitmaps for Redis

MIT License

345 stars 55 forks source link

add r.min/r.max command #58

Closed yihuang closed 5 years ago

aviggiano commented 5 years ago

Hello @yihuang Thank you very much for your contribution! Everything seems correct and well coded. Could you please also include some tests and documentation for both R.MIN and R.MAX? Thesse will be useful for future contributors and users.

unit tests
integration tests
performance tests
documentation on README

yihuang commented 5 years ago

@aviggiano Added tests and readme. There are no unit tests because there seems not much to be tested.

aviggiano commented 5 years ago

Awesome, thank you for this update! I will merge this over the weekend.