search

aviggiano / redis-roaring

Roaring Bitmaps for Redis
MIT License
345 stars 55 forks source link

RedisRoaring coredump while r.optimize on non-existing key #83

Closed arthurkiller closed 3 years ago

arthurkiller commented 3 years ago

image

at line 219

if key did not exist, this should not go through with bitmap_optimize(bitmap);

aviggiano commented 3 years ago

Hi @arthurkiller Thank you for submitting this issue

If I understand correctly, you are getting a core dump (segfault) when using R.OPTIMIZE on a non-existing key? If that's the case, that should probably be a bug. I believe there are tests that cover this case unfortunately I'll check it out, and if this is the case, will submit a fix

aviggiano commented 3 years ago

Whoa, you're already submitting the bugfix! great!!! I'll get that merged once the PR is opened

arthurkiller commented 3 years ago

lol, I was just finished my daily work and planning to submit the code then go home.

thx for your reply. (that's a real-time reply)

arthurkiller commented 3 years ago

closed via #84