Don't extend `Base.log`

avik-pal / Wandb.jl

Unofficial Julia bindings for logging experiments to wandb.ai

https://avik-pal.github.io/Wandb.jl/stable/

MIT License

80 stars 10 forks source link

Closed ericphanson closed 2 years ago

ericphanson commented 2 years ago

As the code-comment says, it's bad practice. What's wrong with asking users to write Wandb.log if they want?

avik-pal commented 2 years ago

Yeah, I think I will remove the overload, and update the docs to ask people to do Wandb.log

darsnack commented 2 years ago

It seems the FluxTraining integration still uses Base.log. Is this intended?

avik-pal commented 2 years ago

No just an oversight. Could you send in a PR?