search

avikpaul / google-url

Automatically exported from code.google.com/p/google-url
Other
0 stars 0 forks source link

GURL: add a PlainHost() method for bracketless IPv6 literals. #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
A URL can contain an IPv6 address literal, like [2001:db8::2].  Users of
the GURL library sometimes need the square brackets, and sometimes don't.

My proposed patch adds a PlainHost() method, which returns the hostname
with brackets chopped off.

Tested using the Chromium source tree:
hammer -C build googleurl_unittests --mode=Release
hammer -C build googleurl_unittests --mode=Debug

Original issue reported on code.google.com by pma...@google.com on 10 May 2009 at 6:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Er, sorry, I'm not very familiar with these tools...

It looks like you guys are using the Chromium codereview system for googleurl
reviews; please forward your attention to http://codereview.chromium.org/113187

Original comment by sparkm...@gmail.com on 10 May 2009 at 6:31

GoogleCodeExporter commented 9 years ago 
HostNoBrackets() was committed in r102
Also see the dialog in issue 2 surrounding this.

Original comment by eroman@chromium.org on 19 May 2009 at 10:35