search

aviks / GameZero.jl

Zero overhead game development library for the Julia programming language
Other
184 stars 23 forks source link

Pass mandatory argument to `initgame` in tests #41

Closed giordano closed 3 years ago

giordano commented 3 years ago

PR #38 added a new mandatory argument to initgame, which however isn't used in tests.

aviks commented 3 years ago

There is a default to that argument, so this should not be required?

Separately, I havent figured out a way to run the game loop in a headless system, so we don't have CI.

giordano commented 3 years ago

There is a default to that argument

Uhm, no:

https://github.com/aviks/GameZero.jl/blob/26b1a22ebe11b2dd4fc8137a569841e585630ef3/src/GameZero.jl#L198

rungame has a default value for external:

https://github.com/aviks/GameZero.jl/blob/26b1a22ebe11b2dd4fc8137a569841e585630ef3/src/GameZero.jl#L179

Maybe a better solution is to give a default value of external (true?) to initgame as well?

aviks commented 3 years ago

Ah, OK, indeed. Actually, this is correct, initgame should not have a default, IMO. I'll add some comments to remind myself what is happening.