aviks / Taro.jl

Read and write Excel, Word and PDF documents in Julia
Other
124 stars 25 forks source link

Upgrade to 1.0 #47

Closed aviks closed 5 years ago

aviks commented 5 years ago

One major backward incompatible change:

readxl now returns an array of NamedTuples. To get a DataFrame as before, pass that to a DataFrame constructor. This change allows you to create any Tables.jl supported container from the xl data. As a result, the dependency on DataFrames.jl is dropped. Instead a dependency on Tables.jl is introduced.

Fix #46

viz:

nt = Taro.readxl("/path/to/file.xlsx", "A1:B10")
using DataFrame
df = DataFrame(nt)
aviks commented 5 years ago

This version of the code is about 1.5x faster in reading large xl files (100000x8)

aviks commented 5 years ago

Fix #40

aviks commented 5 years ago

This is ready, except that tests fail on windows. I don't have a windows machine currently, and debugging via Appveyor is painful. I'd appreciate some assistance -- I imagine it's an issue with the paths.

aviks commented 5 years ago

So the error on windows seems to be due to a bug in JavaCall, which makes it likely that the xml-fo generation part of this package has never worked on windows, even in the released versions. Can anyone confirm?