search

avil13 / vue-sweetalert2

A convenient wrapper for sweetalert2.
https://avil13.github.io/vue-sweetalert2/
656 stars 75 forks source link

Suggestion: Create a vue-sweetalert2 version 3.x to update to sweetalert 9.x #86

Closed vincentdh closed 4 years ago

vincentdh commented 5 years ago

Some breaking changes have been introduced in v9.x of sweetalert2.

I suggest to create a v3.x of vue-sweetalert2 to update the dependency and not breaking projects that are using version 2.x of vue-sweetalert2.

vincentdh commented 5 years ago

This issue is related to issue #75 and can close it

danielalejandromatheus commented 4 years ago

Would be nicer if you were able to pass an instance of Sweetalert in case you want to use newer versions of swal. Something like:

import swal from 'sweetalert2';
import VueSweetAlert2 from 'vue-sweetalert2';
import Vue from 'vue';

Vue.use(VueSweetAlert2, swal)
avil13 commented 4 years ago

This library is just a wrapper for easy use. She always uses the latest major version. V3 just upgraded sweetalert2 to version 9.

Your option negates the meaning of using this library. It will be easier to use sweetalert2 directly, simply adding the library to the components themselves.

But thanks for the idea, maybe I just haven’t understood all its advantages.