search

avinash201199 / weather-app

Weather app with JavaScript and api
MIT License
86 stars 164 forks source link

Merged in single page #283

Closed khemrajshrestha471 closed 11 months ago

khemrajshrestha471 commented 11 months ago

🛠️ Fixes Issue

➕ Changes Introduced

📄 Note To Reviewers

📷 Screenshots

avinash201199 commented 11 months ago

can you please add the demo video

khemrajshrestha471 commented 11 months ago

Please check it.

avinash201199 commented 11 months ago

so you have just added the sourcea and the next ui button is taking to your hosted website right ?

avinash201199 commented 11 months ago

as you have just added the source code the project and have given the link of your hosted project , people connot do the changes if required , so I'm reverting back the pull request . If the complete thing integrated to this project with live hosting also then it's good , but adding other project source code and link is not good for this repo.

khemrajshrestha471 commented 11 months ago

This was the project we had done in our hackathon 2 days back.

When I was rolling an eyes for the repo, I saw a repo of weather app and why not to contribute through our code. So I push our code in your repo.

Please remember, this is not other's code.

Thank You!