search

avinash201199 / weather-app

Weather app with JavaScript and api
MIT License
86 stars 164 forks source link

Changing link target attribute #307

Closed TeekshaHarish closed 11 months ago

TeekshaHarish commented 11 months ago

🛠️ Fixes Issue

Fix for issue #306

➕ Changes Introduced

changed the target attribute of the links of social handles I have tested the code after changes

avinash201199 commented 11 months ago

can you explain about this pr ?

TeekshaHarish commented 11 months ago

The links in the footer of the social media handles like LinkedIn, Github, Instagram were opening in the same tab as of the website, so it makes the simultaneous navigation of website and the social handle site side by side difficult, as to view to website the person has to use the browser back button which removes the progress(or what they were searching on that site) lost and if they want to go back to that site like LinkedIn they would have to start over their searches there,which is not a good user experience according to me. Thus by making the links of social handles like LinkedIn and Insta open in another tab instead of the same one, it provides the user better experience and he/she can switch between your social page and website easily without having to use the back button. To do so i have added the target attribute of the links of social handles

avinash201199 commented 11 months ago

Thank you for your contribution:)