search

avinashbot / redd

Redd is a batteries-included API wrapper for reddit.
MIT License
186 stars 75 forks source link

Added Submission::link and Comment::comment_link #82

Open khalilfazal opened 6 years ago

khalilfazal commented 6 years ago

The method names are confusing. Why does Submission::permalink return a relative path instead of an absolute path? Why does Comment::link return the link to the submission instead of a link to the comment itself?

khalilfazal commented 6 years ago

So I don't think it's my fault that travis can't build. It is having trouble installing jruby.

StephanMeijer commented 6 years ago

Reddit calls a submission also a link. Please suffix your functions with _url instead of _link.

StephanMeijer commented 6 years ago

Maybe change to other link-function to url as well?

StephanMeijer commented 6 years ago

Thank you. I will merge it into my fork (https://github.com/StephanMeijer/redd/)