Closed 0xabdulkhalid closed 1 year ago
Hey there @avinashkranjan 👋🏻
Please make sure to assign this issue to me asap to make the work done!
Thank you.
Go Ahead
@avinashkranjan a person has created a PR for this issue which i was assigned by you without your permisson.
Kindly close his PR and merge my PR to fix this issue.
Thank you for your attention!
The issue is not fixed by your PR. The light mode is not working. Also, the method you used to handle dynamic handling of images is old. I have used the new format syntax for that.
Bro, the light mode is finely working then how can i show the screenshot ?
First of all as a fellow contributor please make sure to follow ethics while contributing.
How can you open a PR without informing the Project Admin or the one who created this ?
Doing these types of stuffs is strictly against contributing guidelines.
Hope you understood, let the Project Admin @avinashkranjan handle this problem.
First, I don't know how are you saying it's working fine when it's clearly not.
Secondly, it was my mistake that I overlooked your commitment and started to work on it. I realised it after making the PR. After which, I didn't even mentioned once to merge my PR after that.
@suman-somu How can you see the image if the page still not properly loaded yet 🤦♂️, the mistake is with your network not my code.
Here's how it looks, just view it from view file from this PR.
I have already told you that you are not permitted to open a PR for which not assigned to you yet, You doesn't follow contributing guidelines here.
Please close that, that's all i can say.
Otherwise it will be closed by Project Admin.
You are using old syntax for image insertion, which is why it's just never loads or takes much time. https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to The mistake is not with my network but with your code itself. And not just arguing over guidelines maybe you should have fixed it when I mentioned it earlier. Also, maintainers know the guidelines you are trying to specify in every message. The guidelines are meant to be for the betterment of the project and the PA will do same.
What's wrong with the existing documentation
Add ScreenShots
Record