search

avinashvarna / audio_alignment

Align various Sanskrit texts and audio
MIT License
12 stars 7 forks source link

Looping Support #8

Closed hrishikeshrt closed 3 years ago

avinashvarna commented 3 years ago

Looks great! Would it be more user-friendly to display the loop start/end times in MM:SS (similar to the audio player) rather than a floating point number of seconds? If I understand the code correctly, this only requires a change to lines 133/139 of align.js that sets the button.innerHTML?

hrishikeshrt commented 3 years ago

Makes sense. I'll make it HH:MM:SS, if that applicable, and MM:SS otherwise.

avinashvarna commented 3 years ago

Change looks good. Thanks again for the awesome contributions!