avinashvarna / audio_alignment

Align various Sanskrit texts and audio
MIT License
11 stars 7 forks source link

several updates #9

Closed hrishikeshrt closed 2 years ago

hrishikeshrt commented 2 years ago

Checkout the display at https://hrishikeshrt.github.io/audio_alignment/

shreevatsa commented 2 years ago

I'm just watching this repo and didn't look at the change, but glad to see there's still interest in this :-) Thanks for working on this!

(BTW, one piece of feedback is that when I pointed someone to the website, they were not able to figure out that they need to click on the sidebar on the left: they tried to click on the "Text Source" and "Audio Source" links. Maybe a "Go to first chapter" or "Start playing" link would help…)

avinashvarna commented 2 years ago

Thanks Hrishikesh for implementing all these enhancements! I think @shreevatsa's comment is very useful from the perspective of someone visiting the site for the first time. Along those lines, a couple of quick comments:

hrishikeshrt commented 2 years ago

I'll add a help page to explain audio controls soon. Without accordion interface was developed as a part of another project, that has been implemented for the sake of demonstration, where individual pages were embedded into other pages. Setting accordion to true in data.json will get rid of that. I'll push that change as well.

hrishikeshrt commented 2 years ago

Fixed accordion and added help page, which is referenced from the landing page.

avinashvarna commented 2 years ago

Thanks! I think it would be nice to have the help linked in the audio controls <div> as well, since a direct link to a particular page would bypass the landing page. If you get a chance, please add it to this PR. If not, we can add it later.

I'll open a separate issue if necessary, to address the point that Shreevatsa made about adding a "Go to first chapter" sort of link.

hrishikeshrt commented 2 years ago

Added an always on top help icon on every page. I want to add a "continue to next chapter" link as well (or perhaps even a toggle at the top, "Auto-Advance" that will continue to the next chapter after one chapter is done, but I'll work on it a bit later)

avinashvarna commented 2 years ago

Thanks for all the updates!