avinetworks / avi-helm-charts

Avi Networks Helm Charts
14 stars 26 forks source link

imagePullSecrets template wrong format #114

Closed zm1990s closed 3 years ago

zm1990s commented 3 years ago

In statefulset.yaml line 19~21, imagePullSecrets's value is wrong, it should be - name: {{ toYaml . }}

    {{- with .Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}

Fix:

    {{- with .Values.imagePullSecrets }}
      imagePullSecrets:
        - name: {{  toYaml . }}
    {{- end }}
sudswasavi commented 3 years ago

hi @zm1990s If you'd still like someone to take a look at this issue, can you pls file this issue here: https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes ? We would be retiring this repo soon in favour of the source code repo.

zm1990s commented 3 years ago

Moved to https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes/issues/589