search

avioli / uni_links

Flutter plugin for accepting incoming links.
BSD 2-Clause "Simplified" License
563 stars 303 forks source link

Migrate to Flutter 2 #104

Closed orevial closed 3 years ago

orevial commented 3 years ago

I propose this PR to migrate the plugin to Flutter 2 framework so null safety is recognized when using the dependencies. I think this was the only thing to do in order for the plugin to be recognized as "Null safe" in pub.dev as you already migrated to Dart 2.12+ and all code was already null safe (thanks for the awesome job 🎉 ).

Note that I've updated pedantic package which new version is now null safe by default.

Closes #103

bhavin-concetto commented 3 years ago

@Arcturus5404 can you merge the changes or need to more review?

justacid commented 3 years ago

Instead of opening yet another PR, I'll just wanted to comment that this PR probably should bump the major version of plugin_platform_interface in every pubspec.yaml too - otherwise uni_links will be incompatible (and need a dependency override) with e.g. the null-safe version of the file_picker package which depends on ^2.0.0.

objectivecosta commented 3 years ago

Bump!

Arcturus5404 commented 3 years ago

@Arcturus5404 can you merge the changes or need to more review?

I don't have write access

orevial commented 3 years ago

Just bumped plugin_platform_interface as suggested by @justacid.

@avioli could you please have a look at the PR and merge if it seems OK ?

BringTheChill commented 3 years ago

I really hope that it will be merged soon

Arcturus5404 commented 3 years ago

has anyone heard from @avioli recently?

ericmartineau commented 3 years ago

I needed this, so I temporarily released uni_links2 which includes the nfc PR and the null-safety PR. I'm happy to make anybody a contributor for that repository.

cloudbreakstudios commented 3 years ago

Is there any update on when this will be merged?

SAGARSURI commented 3 years ago

is there any update on this?

MisterJimson commented 3 years ago

@ericmartineau Can you enable issues on that repo? May need to support it there for a while as we are not seeing progress here.

binish784 commented 3 years ago

any updates on the merge ?

lukasloh commented 3 years ago

@avioli Could we please get this merged in? It's the last non-null safe package I'm dependent on. Thanks!

avioli commented 3 years ago

@orevial Thanks

davidpanic commented 3 years ago

@ericmartineau You should mark that package as discontinued on pub.dev now.

JamesMcIntosh commented 3 years ago

I needed this, so I temporarily released uni_links2 which includes the nfc PR and the null-safety PR. I'm happy to make anybody a contributor for that repository.

@ericmartineau Please mark the uni_links2 packages as discontinued immediately if you are not going to develop it further as a project. Having this package available is creating confusion as you would expect this to be a successor to uni_links. Issue tickets are been starting to be raised with issues related to uni_links2.

Please see the following link for instructions on how to do discontinue the package so it no longer appears in the pub search: https://dart.dev/tools/pub/publishing#discontinue