[DEPRECATED METHOD] UniLinksPlugin.java Line 68 getFlutterEngine()

avioli / uni_links

Flutter plugin for accepting incoming links.

BSD 2-Clause "Simplified" License

564 stars 317 forks source link

[DEPRECATED METHOD] UniLinksPlugin.java Line 68 getFlutterEngine() #70

Open corsojulian7 opened 4 years ago

corsojulian7 commented 4 years ago

Describe the bug File: uni_links-0.4.0/android/src/main/java/name/avioli/unilinks/UniLinksPlugin.java Line: 68 Deprecated Line: register(flutterPluginBinding.getFlutterEngine().getDartExecutor(), this);

To Reproduce Steps to reproduce the behavior: 1.Compile

Expected behavior Expected to pass build without warnings

Smartphone (please complete the following information):

Device: [e.g. Moto Z3 Play, Android Emulator]

Additional context Nothing else to comment.

bradsb commented 4 years ago

Android emulator API 29 and 30 for me after flutter clean. Haven't tried others Flutter 1.20.2

Note: ~/.pub-cache/hosted/pub.dartlang.org/uni_links-0.4.0/android/src/main/java/name/avioli/unilinks/UniLinksPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

bradsb commented 4 years ago

The flutter team just merged in a pull request and released an update to suppress these warnings in url_launcher

https://github.com/flutter/plugins/pull/3132

Might be reasonable to do the same here