aviralkumar2907 / CQL

Code for conservative Q-learning
408 stars 70 forks source link

Function argument problem about expl_path_collector.collect_new_paths() #2

Closed SongyiGao closed 3 years ago

SongyiGao commented 3 years ago

In code "cql_mujoco_new.py", define expl_path_collector

https://github.com/aviralkumar2907/CQL/blob/master/d4rl/examples/cql_mujoco_new.py#L65

https://github.com/aviralkumar2907/CQL/blob/d67dbe9cf5d2b96e3b462b6146f249b3d6569796/d4rl/rlkit/samplers/data_collector/path_collector.py#L117

In "batch_rl_algorithm.py", use the expl_path_collector.collect_new_paths, when use the expl_path_collector.collect_new_paths(), should give the policy_fn args. https://github.com/aviralkumar2907/CQL/blob/d67dbe9cf5d2b96e3b462b6146f249b3d6569796/d4rl/rlkit/core/batch_rl_algorithm.py#L110

SongyiGao commented 3 years ago

I have an error understand about the code.