avishaan / lightTribe

LightTribe Backend and Collaboration Doc
2 stars 0 forks source link

GET /v1/conversations is responding with image id instead of image URL #91

Closed footnote closed 8 years ago

footnote commented 8 years ago

Still getting this response

Try to hit this url: http://lighttribe-dev.herokuapp.com/api/v1/conversations?access_token=S362u7bFRqRvJo53Zv

{
_id: "560073deb0fa221400aa3371",
__v: 0,
participants: [
{
_id: "5599bfa6be10e91400dabbc3",
username: "sob",
password: "$2a$09$vLTup3mTIEF9GFD/WdWgJ.VZhtOE7lsmLZZt1ZNpRjxJ3UQanX.q6",
__v: 3,
userImage: "561fdfd0205a6514006cdeef",
follows: [
"54f44c5d26352b1b9755b12f",
"56192c92d53c0a4500989c84"
],
devices: [ ],
interests: [
"Yoga",
"Rugby"
],
profile: {
shortDescription: "Fill in the service you have to offer"
},
token: {
expires: "2015-07-05T23:37:10.511Z",
value: "S362u7bFRqRvJo53Zv"
}
}
],
createDate: "2015-09-21T21:17:18.663Z"
},
avishaan commented 8 years ago

Thanks for sharing the route, makes it easier to look into.

avishaan commented 8 years ago

Stuck on this, can't figure out why our test cases pass but this example data you shared doesn't populate.

avishaan commented 8 years ago

Oh I see, on the phone you described this route as getting a specific conversation. Not getting the list of conversations. That's why it still doesn't work for you because the route you described on the phone was fixed, not this one.

avishaan commented 8 years ago

This turns out to be one of the most computationally expensive queries, if we don't get up using the thumbnails when looking at the list of conversations let's revisit this and potentially remove that population step. For now we will go ahead and implement this.

avishaan commented 8 years ago

This is the new response. image