avishai84 / numbers

0 stars 0 forks source link

useEffect has no meaning #6

Open tamirla opened 4 years ago

tamirla commented 4 years ago

https://github.com/avishai84/numbers/blob/39ce4d0c20109a2428dc40f1f9256a492e0caa14/src/components/Audio.jsx#L39

why you don't initialize it as true ? useEffect has no meaning in this case. also its dependencies are not relevant

avishai84 commented 4 years ago

Good catch, I'll update and remove it.