search

avishayil / react-native-restart

React Native Package With One Purpose: To Restart Your React Native Project
MIT License
926 stars 145 forks source link

Cleanup (onDropViewInstance) of React Native Modules on Android not working #243

Open hohler opened 1 year ago

hohler commented 1 year ago

When RNRestart.Restart() is executed, I need to clean up some custom modules on Android.

With the dev metro server running, it executes onDropViewInstance inside a RN Module ViewManager which extends SimpleViewManager (which extends in the end BaseJavaModule) correctly on restart. So I can destroy some views if needed.

But with a release (or even debuggable) build, but without using the dev server, this function is not called at all (I also checked others like invalidate, onCatalystInstanceDestroy, onHostDestroy, but those won't work).

How can I cleanup stuff inside a module / ViewManager when the app is running standalone without a dev server?

Is this a bug, or why is onDropViewInstance not called?

freeboub commented 10 months ago

Did you try to use onDestroy in android activity ?