avisi-cloud / structurizr-site-generatr

Static site generator for architecture models created with Structurizr DSL
https://avisi-cloud.github.io/structurizr-site-generatr/
Apache License 2.0
229 stars 35 forks source link

setting element.url causes plantuml syntax errors in context views when using the c4 exporter on Windows #612

Closed zhelyan closed 1 month ago

zhelyan commented 1 month ago

an odd one

This example works:

 workspace  { 

    !identifiers hierarchical  

    model {
       properties { 
          "structurizr.groupSeparator""/"  
       }

        a = softwareSystem "A" {
          // url https://yahoo.com 
        }

        b = softwareSystem "B"

        softwareSystem "C" {
             -> a  
             -> b 
        }
   }   
    views {
        properties  {
            "generatr.site.nestGroups" "true" 
            "generatr.site.exporter" "c4"  
            "c4plantuml.relationshipProperties" "true"  
            "c4plantuml.elementProperties" "true"
            "c4plantuml.tags" "true"
            "c4plantuml.legend" "true"
            "c4plantuml.stereotypes" "true"  
        }
    }
}

but uncommenting url https://yahoo.com under system A leads to a plantuml error shown on the system C context page (apologies for the quality, no other way to share ... ). The error disappears if I set c4plantuml.elementProperties to false

20240923_192825

I have verified that the plantuml files generated by the site generatr tool from the above example are syntactically correct ( parsing, exporting to e.g png all worked fine).

zhelyan commented 1 month ago

Turns out that the same happens if I add properties to an element.

The generated standalone png, svg and puml files render just fine but the svg embedded in the html is corrupted