search

avit / rspec-rails-caching

RSpec helpers for testing page and action caching in Rails
MIT License
12 stars 7 forks source link

Update matchers to be compatible with RSpec 3 #6

Closed cgunther closed 6 years ago

cgunther commented 9 years ago

Thanks for this gem!

This updates the matchers to work with RSpec 3 and not issue deprecations.

I updated the gemspec to rely on RSpec 3 or higher, though with some more work I suppose the changes could be adapted to support both RSpec 2 and 3, but I'm not sure if there's value in that.

The test suite passes as well as the test suite for my application using these matchers.

avit commented 8 years ago

Oh wow @cgunther, sorry I didn't see this here. Reviewing now and I'll merge it for a new release.

@markedmondson these implementations are really similar to yours. From what I can tell at a glance, this pull request gets it done more directly with module_eval and it adds a definition for supports_block_expectations as well... Can you try what you need with this branch & see if it works?

cgunther commented 6 years ago

If you're looking to cut a new release soon, would you mind merging this too? That'd allow me to depend on a proper version of this gem rather than my fork. Thanks!

cgunther commented 6 years ago

Awesome, thanks for the merge!