search

avito-tech / Paparazzo

Custom iOS camera and photo picker with editing capabilities
MIT License
779 stars 82 forks source link

Add iPhone X support #48

Closed HiveHicks closed 5 years ago

jackpaster commented 7 years ago

@HiveHicks hello, I opened the same issue and you told me you would have the project fully functional with iPhone X. There’s still a lot of issues that need to be issues with the design. When are you positive you will have it all done. I just need to know when so I can release my app.

HiveHicks commented 7 years ago

@jackpaster sorry to keep your waiting, it was a busy week for me. There are still a few issues with iPhone X, but most of the work is done. Use develop branch to stay up-to-date until we release 2.1.0.

jackpaster commented 7 years ago

The size of each image in the picker when your scrolling through the images you can edit in the slider are massive. And there’s a bug when you click the photo library button for the first time the cancel and done buttons don’t layout. Do you think you can have the look and these small things that make a big difference done this week. I’m really overdue for release that’s why I’m asking.

jackpaster commented 7 years ago

@HiveHicks when will 2.1.0 be released. Is there a timeline

HiveHicks commented 7 years ago

The size of each image in the picker when your scrolling through the images you can edit in the slider are massive. And there’s a bug when you click the photo library button for the first time the cancel and done buttons don’t layout

As I already said, you need to use develop branch. These bugs have already been fixed there.

In your Podfile:

pod 'Paparazzo', :git => 'https://github.com/avito-tech/Paparazzo', :branch => 'develop'
HiveHicks commented 7 years ago

That's how Paparazzo looks like on iPhone X in develop

2017-11-21 16 03 40 2017-11-21 16 03 58
jackpaster commented 7 years ago

@HiveHicks you said there are still a few issues that need to be fixed. If it looks good like you said. What are the few issues that need to be fixed for the iPhone X. And when do you expect to complete them all. Thanks

HiveHicks commented 7 years ago

@jackpaster everything should be fixed now in develop branch. If you find any issues, feel free to post it here.

jackpaster commented 7 years ago

@HiveHicks Two questions. Can you merge the new design for the photo library with the develop branch and make it one whole branch, and can you make the new photo library design iPhone x compatible. What is the timeline for these two requests do you think

jackpaster commented 7 years ago

@HiveHicks What do you think will you eventually merge the two branches and will the photo library be updated to iPhone x

HiveHicks commented 7 years ago

This feature is being tested at the moment. We will merge it into develop as soon as it's approved by our QA specialists. Hopefully this week, but I can't tell you the exact date.

jackpaster commented 7 years ago

@HiveHicks thanks its a great update. I love the updated design so much so I hope you guys get it in really soon