search

avito-tech / Paparazzo

Custom iOS camera and photo picker with editing capabilities
MIT License
779 stars 82 forks source link

Add partial support for iPhone X #57

Closed u2606 closed 7 years ago

u2606 commented 7 years ago

Partial support for #48.

Photo library picker:

Old:

(Automatically scrolls too far, and shows photos between navigation bar and top of screen)

screen shot 2017-10-31 at 01 27 54

New:

screen shot 2017-10-31 at 01 28 31 screen shot 2017-10-31 at 01 28 57

Camera

Old:

(Buttons and “Photo 1” text too high)

screen shot 2017-10-31 at 01 28 02

New:

screen shot 2017-10-31 at 01 29 17

Same photo on iPhone 6s, for comparison:

screen shot 2017-10-31 at 01 27 33

Already supporting iPhone X:

Circle cropper:

screen shot 2017-10-31 at 01 43 10

Still not supporting iPhone X:

Photo library in landscape:

(Photos too close to left and right edges)

screen shot 2017-10-31 at 01 30 19

Camera in landscape:

(Buttons to close to “top” [physical top of phone, not virtual top of screen])

screen shot 2017-10-31 at 01 30 13

Edit tool:

screen shot 2017-10-31 at 01 44 14

u2606 commented 7 years ago

I can make the requested changes, but won’t be able to get back to this for a few days. If you’d like the changes sooner, this PR is actually already allows edits from maintainers of this project:

allowed-edits-from-maintainers