search

avito-tech / Paparazzo

Custom iOS camera and photo picker with editing capabilities
MIT License
779 stars 82 forks source link

Swift 4 support #59

Closed mahmoudkhudairi closed 5 years ago

mahmoudkhudairi commented 7 years ago

Thanks for the awesome framework please can you update it to Swift 4 to support new apps built in swift 4. Keep Up the good work  

HiveHicks commented 7 years ago

@mak21, there shouldn't be any issues with integrating Paparazzo in Swift 4 app as long as Swift 3.2 and 4.0 can exist in a single project. The latest version of Cocoapods supports that.

DogandElk commented 6 years ago

I added the dependency by adding it through Cocoapods and when I tried to run the app I received all kinds of errors stating that the code had been deprecated plus there is an error in the task that makes the app crash. What a waste of time. I am in Xcode 9.2 Swift 4

HiveHicks commented 6 years ago

@DogandElk what version of Cocoapods are you using?

DogandElk commented 6 years ago

How do I determine that ?

On Dec 21, 2017, at 4:27 AM, Andrey Yutkin <notifications@github.com mailto:notifications@github.com> wrote:

@DogandElk https://github.com/dogandelk what version of Cocoapods are you using?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avito-tech/Paparazzo/issues/59#issuecomment-353315821, or mute the thread https://github.com/notifications/unsubscribe-auth/AfpLy0D6gB9Efh8sKjwXxEN8Bnc7iMjBks5tCjKYgaJpZM4QXcwj.

DogandElk commented 6 years ago

Version 1.3.1

On Dec 21, 2017, at 11:29 AM, Thomas GlodekMD twglodek@gmail.com wrote:

How do I determine that ?

On Dec 21, 2017, at 4:27 AM, Andrey Yutkin <notifications@github.com mailto:notifications@github.com> wrote:

@DogandElk https://github.com/dogandelk what version of Cocoapods are you using?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avito-tech/Paparazzo/issues/59#issuecomment-353315821, or mute the thread https://github.com/notifications/unsubscribe-auth/AfpLy0D6gB9Efh8sKjwXxEN8Bnc7iMjBks5tCjKYgaJpZM4QXcwj.

voluntas88-xsolve commented 6 years ago

I set Swift Language Version to 3.2 for Paparazzo in Build Settings and it helped me with compile errors. Also it should be done after every pod update.

HiveHicks commented 6 years ago

I've migrated Paparazzo to Swift 4 in swift-4 branch and found the reason for empty camera view. It will soon be merged into develop. See #64.

DogandElk commented 6 years ago

That sounds Great ! I'll be looking forward to hearing from you when it is ready .

Happy New Year !

Tom

On Dec 31, 2017, at 4:54 AM, Andrey Yutkin <notifications@github.com mailto:notifications@github.com> wrote:

I've migrated Paparazzo to Swift 4 in swift-4 branch and found the reason for empty camera view. It will soon be merged into develop.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avito-tech/Paparazzo/issues/59#issuecomment-354597477, or mute the thread https://github.com/notifications/unsubscribe-auth/AfpLy0u0qJPVL-0CVZ3L-WOvOQq3iMx2ks5tF2fogaJpZM4QXcwj.

DogandElk commented 6 years ago

Happy New Year !

We are wondering when you will post the updated changes so we can update our pod file ?

On Dec 31, 2017, at 4:54 AM, Andrey Yutkin <notifications@github.com mailto:notifications@github.com> wrote:

I've migrated Paparazzo to Swift 4 in swift-4 branch and found the reason for empty camera view. It will soon be merged into develop.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avito-tech/Paparazzo/issues/59#issuecomment-354597477, or mute the thread https://github.com/notifications/unsubscribe-auth/AfpLy0u0qJPVL-0CVZ3L-WOvOQq3iMx2ks5tF2fogaJpZM4QXcwj.

HiveHicks commented 6 years ago

@DogandElk I'm on vacation right not, so the pull request with this migration is expected to be merged only on January 9th or so. Meanwhile you can use swift-4 branch of the pod in your Podfile.

DogandElk commented 6 years ago

Hi,

Any word on the update ?

On Jan 5, 2018, at 1:29 PM, Andrey Yutkin <notifications@github.com mailto:notifications@github.com> wrote:

@DogandElk https://github.com/dogandelk I'm on vacation right not, so the pull request with this migration is expected to be merged only on January 9th or so. Meanwhile you can use swift-4 branch of the pod in your Podfile.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avito-tech/Paparazzo/issues/59#issuecomment-355643758, or mute the thread https://github.com/notifications/unsubscribe-auth/AfpLyxo-0XmDbJ8_wVmDxN12zd3ij560ks5tHngLgaJpZM4QXcwj.

HiveHicks commented 6 years ago

Swift 4 support is merged into develop

rjjohnpatrickcruz commented 6 years ago

This library is awesome, I just want to know updates in swift 4 conversion. Thank you! Cheers!

bystritskiy commented 6 years ago

@HiveHicks Hi! When will the release? Thank you

HiveHicks commented 6 years ago

@rjjohnpatrickcruz @bystritskiy you can use the latest development version if you need Swift 4 support. It's production ready.

To do that you need to specify in your Podfile:

pod 'Paparazzo', :git => 'https://github.com/avito-tech/Paparazzo', :branch => 'develop'

You can treat this as Paparazzo 3.0 beta. We still need to complete some tasks in order to publish the final version in Cocoapods repo.

fabiojgrocha commented 6 years ago

@HiveHicks it would have to be: pod 'ImageSource', :git => 'https://github.com/avito-tech/Paparazzo', :branch => 'develop' pod 'Paparazzo', :git => 'https://github.com/avito-tech/Paparazzo', :branch => 'develop'