search

avito-tech / go-transaction-manager

Transaction manager for GoLang
MIT License
231 stars 14 forks source link

Bump Go version to 1.23 #107

Closed maranqz closed 1 month ago

maranqz commented 2 months ago
  1. bump up go version
  2. fix test running. Currently tests always pass because no exit code is sent for tests. I fixed this, and also the driver tests only run on go versions and higher that are installed in go.mod.
coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10707440316

Details

Totals Coverage Status
Change from base Build 10230849578: -0.1%
Covered Lines: 1615
Relevant Lines: 1711
💛 - Coveralls
AlexeyKupershtokh commented 2 months ago

Hey Ilia.

Please consider that gh action started upgrading go 1.21 to 1.22 automatically. https://github.com/avito-tech/go-transaction-manager/actions/runs/10230981994/job/28306419497#step:3:14 Check the "install go" section there.

There's an article and a possible fix for this: https://brandur.org/fragments/go-version-matrix