search

aviv-official / xvault-web

Web frontend for XVault
https://aviv-official.github.io/xvault-web/
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Send Error #5

Open moondancer762 opened 5 years ago

moondancer762 commented 5 years ago

I sent 1 ETH from 0x2923E1ED2937bA0eB00e1872A6665eE96a5b930b to 0xc2d877df66918A359A7F4B774e9C948Ec2b3fEaa in Xvault. I look on Etherscan: A.) The from address shows 0 sent, but I paid gas B.) The to address shows nothing (obviously) C.) Dammit, I don't remember what the drop down showed, but I believe it was just to confirm the transaction. I'll pay attention better next time.

sshelton76 commented 5 years ago

Is this the offending transaction? https://rinkeby.etherscan.io/tx/0xb6e70d5cc3601b7f336a5ab1239086e8afaf664567c6957f43b556858056ae06

sshelton76 commented 5 years ago

It appears there is a problem with the XETH contract. For now just try the others.

sshelton76 commented 5 years ago

I got this to work with https://rinkeby.etherscan.io/tx/0xfd38b57b58e624d2308ac3229a7761517d42c2437e6c668badb6f74871ea7983

It looks like the first time a contract is used to mint tokens, the gas requirement is much higher. I'll make sure we're sending along 60k gas just to stay on the safe side.

sshelton76 commented 5 years ago

I've pushed a fix, please do a hard refresh and try again.

moondancer762 commented 5 years ago

Tried sending again 1.01 xETH. Nothing sent, but I paid gas. I don't understand how to adjust gas or why it fluctuates so terribly, so I just let the program choose gas. Many customers will be in the same boat, especially the older crowd and newbies. I used the same addresses as before. Could this, and the fact I show no xETH in the field above the QR code, have something to do with the fact I was not prompted for a PIN when I first set up the account? Does anyone else have this issue?

sshelton76 commented 5 years ago

Yes if you were never prompted for a PIN when you created the account, then there is no wallet that XVault is working with. Sounds like something got borked. I'm going to change up a few things here so that doesn't happen in the future. For now, just eliminate your cookies and cache and try again.

moondancer762 commented 5 years ago

Did that, still cannot send, tried to send 1.03 ETH, but just paid WEI gas again. Do you want to continue trying, in case this happens with a real customer and with real funds, or would you rather delete my account and let me create a new account?

sshelton76 commented 5 years ago

Everything is happening clientside. So I can't be the one to delete anything. However I did just add a feature that allows you to restore an account from a mnemonic. So maybe we try that?

moondancer762 commented 5 years ago

I restored my account from the mnemonic, and tried to send 1.05 ETH from 0x2923E1ED2937bA0eB00e1872A6665eE96a5b930b to 0xc2d877df66918A359A7F4B774e9C948Ec2b3fEaa. I saw an errow message: "Params are not identified" or was it "Params are not set" - one of the two. No, "Params is not defined." I had to try sending 1.06 to make sure I had the right error message. Neither 'send' worked.

moondancer762 commented 5 years ago

ABILITY TO ADJUST GAS Shouldn't users be able to adjust the amount of gas to initially be sent with a transaction, in case they want to ensure a transaction gets through quickly, if necessary? I don't see this option in XVault. I do see it in MetaMask. I still don't understand gas, but this may be an important function.

sshelton76 commented 5 years ago

ABILITY TO ADJUST GAS Shouldn't users be able to adjust the amount of gas to initially be sent with a transaction, in case they want to ensure a transaction gets through quickly, if necessary? I don't see this option in XVault. I do see it in MetaMask. I still don't understand gas, but this may be an important function.

You should put that over in https://github.com/aviv-official/xvault-web/issues/9 But long story short. Gas is only a thing on Ethereum, the fact that you don't understand it means that millions of others won't either. When we launch AVIV the whole concept of gas goes away. So adding a UI to make it more like metamask is just going to confuse the end users.

Gas for a transaction has 2 parts. You have the units of gas and this is a fixed quantity per operation. Then you have the price per unit of gas and this changes based on the needs of the network. The units of gas are estimated by the backend based on previous transactions of the type that have been successful. But the estimator does not always account for everything and can sometimes get that number wrong. The price per unit though, this is coming from another process that is watching all the transactions on the network happen and it is recommending an average. What metamask does is it offers the same median average cost per unit, but then also offers double the price per unit in hopes it will go quicker, and half the price per unit in case you want to save money. In the end it amounts to very little one way or the other and the network doesn't tend to actually prioritize higher per unit prices when it is more than 1 std deviation away from the mean. In fact it might go slower since many scam services tell their customers to send with a few std deviations above the mean in order to get mined more quickly. Miners have picked up on that and will often deprioritize transactions that are offering too many wei per unit. So this is why that feature is highly unlikely in xvault.

sshelton76 commented 5 years ago

I restored my account from the mnemonic, and tried to send 1.05 ETH from 0x2923E1ED2937bA0eB00e1872A6665eE96a5b930b to 0xc2d877df66918A359A7F4B774e9C948Ec2b3fEaa. I saw an errow message: "Params are not identified" or was it "Params are not set" - one of the two. No, "Params is not defined." I had to try sending 1.06 to make sure I had the right error message. Neither 'send' worked.

I just found and fixed that, do a hard refresh and try again.

moondancer762 commented 5 years ago

Tried sending 1.01 ETH to rom 0x2923E1ED2937bA0eB00e1872A6665eE96a5b930b to 0xc2d877df66918A359A7F4B774e9C948Ec2b3fEaa. I received error "CTR not defined."

moondancer762 commented 5 years ago

Tried sending 1 ETC to rom 0x2923E1ED2937bA0eB00e1872A6665eE96a5b930b to 0xc2d877df66918A359A7F4B774e9C948Ec2b3fEaa. I received error "CTR not defined."