Closed OnkelTem closed 2 years ago
As for a fix, the easiest way to repair is perhaps just to take the first match. E.g
if [ ! -n "$FONT_VERSION" ]; then
FONT_VERSION=$(curl -s https://github.com/be5invis/Iosevka/releases/latest \
| grep -Po '(?<=tag/v)[0-9.]*' | head -1)
fi
Thanks @OnkelTem !
Running docker container w/o FONT_VERSION now leads to command abortion. See: https://github.com/be5invis/Iosevka/issues/1340#issuecomment-1115994078
The problem is that this code from https://github.com/avivace/iosevka-docker/blob/master/run.sh:
isn't doing what it's expected to.
First, https://github.com/be5invis/Iosevka/releases/latest returns HTTP 302 (redirect) and hence the output of
curl -s https://github.com/be5invis/Iosevka/releases/latest
is an empty string. With this empty string as version it then tries to download the release hereAdding
-L
flag to the curl invocation would lead us to a page like https://github.com/be5invis/Iosevka/releases/tag/v15.2.0. Applying the regexp to which gives:as FONT_VERSION variable.
The most simple workaround would be to use FONT_VERSION set to "dev", e.g.: