search

avivace / iosevka-docker

Docker containers to build custom (or upstream) versions of the Iosevka typeface and package them for Debian
https://hub.docker.com/r/avivace/iosevka-build
Creative Commons Zero v1.0 Universal
29 stars 12 forks source link

Fixed silent error on /tmp/build already existing #14

Closed AZMCode closed 2 years ago

AZMCode commented 2 years ago

Fixed not using GitHub REST API to get latest release

See my interactions in avivace/iosevka-docker#13

AZMCode commented 2 years ago

Thank you for the swift response!

AZMCode commented 2 years ago

I must warn you that this specific script, due to the regex at the end, will fail if a release is ever made in a format other than v([0-9]+\.)*[0-9]+

The regex could be replaced so that it only fails if the format deviates from v.*

AZMCode commented 2 years ago

But it's guaranteed to always be parsing the last release tag.

cbrinker commented 1 year ago

Can you push an updated docker image with this change up to docker-hub? I was able to manually build but it would have been much nicer if docker pull avivace/iosevka-build could have resolved the silent error. Thanks!