Feedback from davidino - Githubissues

avivace / iosevka-docker

Docker containers to build custom (or upstream) versions of the Iosevka typeface and package them for Debian

https://hub.docker.com/r/avivace/iosevka-build

Creative Commons Zero v1.0 Universal

29 stars 12 forks source link

Open avivace opened 3 years ago

avivace commented 3 years ago

Some feedback from @dcasella

[ ] ! -n -> -z if [ ! -n "$FONT_VERSION" ]; then can be if [ -z "$FONT_VERSION" ]; then so you can remove the !

if ! test -f "/build/private-build-plans.toml"; then -> if [ ! -f '/build/private-build-plans.toml' ]; then