search

avivace / ror2-server

Host your own Risk of Rain 2 dedicated server. No technical skills required. Runs everywhere.
https://hub.docker.com/r/avivace/ror2server
GNU General Public License v3.0
169 stars 29 forks source link

Move install to build #52

Closed samikool closed 1 year ago

samikool commented 1 year ago

This change moves the install of ror2 to the building of the container. This allows the user to start and stop the server without having to redownload the game each time.

samikool commented 1 year ago

After looking around I noticed that the install was originally done in the Dockerfile, and then moved to the entry script to shrink the image (#22). Since that disk space is used when the server launches anyway, I don't see a reason to try and save that space.

dcasella commented 1 year ago

We don't install RoR2 at build time because that would require a rebuild+tag+push everytime the application gets updated upstream. While this is the best practice (I fully understand and agree), I don't think we have the time to support it (manually or by implementing a CI/CD which would do it automatically).

samikool commented 1 year ago

Sorry I don't think I understand. Where would you have to rebuild+tag+push too if the application got updated? And which application are you talking about exactly, RoR2? It's no big deal if you guys don't want to merge this, I'm just trying to understand.

Edit: Ah okay I see now. I didn't realize you guys had this image on the Dockerhub. It makes sense now, I'll go ahead and close the pull request.