search

avivbiton / BlizzardApiReader

.Net Core library to handle Blizzard public APIs
MIT License
35 stars 36 forks source link

Separate project for each game API #18

Closed linahanner closed 5 years ago

linahanner commented 5 years ago

For the use case where a developer wants the reader for the World of Warcraft API but not the Diablo API the project will contain an unnecessary amount of models and implementations. I suggest separating the Readers and Models of the various Game APIs into multiple projects, one for each game all contained within the solution.

That is to say the BlizzardApiReader solution would look as follows (as an example):

This way the projects can be compiled into separate packages which are modular and contains no more than is relevant for the use case of that specific package, yet at the same time granting the ability to reference all of the packages in the event that a developer wants the ApiReader for multiple Game APIs.

I can implement this over the weekend, @avivbiton. What do you think?

avivbiton commented 5 years ago

I've seen your changes you made to your forked repo and I really like them and would like to push them forwards. Gj

linahanner commented 5 years ago

@avivbiton Pull request: #19

Have a look whenever possible, it includes refactoring of quite a few parts, as written in the description of the pull request.

avivbiton commented 5 years ago

merged!