Api migrate - Githubissues

avivbiton commented 5 years ago

Notable changes: URLs have changed to the new API Extracted HttpRequests behind an interface to allow better unit testing Added Client Auth SendTokenRequest() needed to be called before GetAsync GetAsync In ApiReader now throws exception when response code is not successful.

ApiConfiguration has changed to accept ClientSecret and ClientID instead of ApiKey Therefore, the ApiConfigurationTests needs to be updated (Commented them for now)

I won't merge until we're sure this is ready and don't cause any problem. So far, I've tested it on a couple diablo apis and it seems fine for the most part.

linahanner commented 5 years ago

I will have a look and verify everything works

linahanner commented 5 years ago

Have run the code on my personal computer - nice! Have suggested some minor changes in pull request #39

I could create an additional interface layer starting from the ApiReader with two separate implementations (one for the old Developer Portal and one for the new Developer Portal).

avivbiton commented 5 years ago

Added tests

avivbiton commented 5 years ago

@linahanner I feel we shouldn't implement the old portal, it will go away soon anyway, I don't see the point of keeping it and then removing it a year later.

avivbiton commented 5 years ago

Anything else we need to add before merging?

linahanner commented 5 years ago

Nothing which comes to mind

avivbiton / BlizzardApiReader

Api migrate #38