search

avivbiton / BlizzardApiReader

.Net Core library to handle Blizzard public APIs
MIT License
35 stars 36 forks source link

Add SC2 Community API #4

Open avivbiton opened 6 years ago

avivbiton commented 6 years ago

The api docs can be found here https://dev.battle.net/io-docs

markfila commented 5 years ago

I can spend some time on Sunday creating some model classes for this.

avivbiton commented 5 years ago

okay thanks

oisinmcl commented 5 years ago

Hi avivbiton and markfila,

Is this still being worked on or is this something I could have a go at? I have some free time this weekend.

Thanks Oisin

markfila commented 5 years ago

I started working on this, but when I went to try some of the calls, I didn't see that blizzard setup a test account like with the wow ones. I couldn't figure out how to find the information on my blizzard account to be able to enter it into the parameters blizzard needs on documentation site in order to see how the responses come back. If you want to take a stab at it, I haven't committed anything.

oisinmcl commented 5 years ago

Hi markfila,

I will work on this when I have free time here and there. As you say, getting the info needed to run a request was a bit tricky but now to decipher the responses.

Thanks

oisinmcl commented 5 years ago

@avivbiton what are the rules on coverage of the API before creating a pull request? I have some endpoints return empty objects due to my account not having that specific data.

Also if you had time could you review my fork to see if there is anything obvious am I doing wrong/doesn't conform.

avivbiton commented 5 years ago

@oisinmcl As long as it works and you leave a comment saying it's unfinished. We don't have documentation set up, just a TODO comment should be fine for now.
I've been pushing with other personal projects lately, I'll come back to this project later, meanwhile It still open for pull requests and I'm still actively responding to issues.
Don't be afraid to make a pull request, even if it has some problems we can comment in your pull requests and allow you to make changes before pushing it into the main branch.