search

avivbiton / BlizzardApiReader

.Net Core library to handle Blizzard public APIs
MIT License
35 stars 36 forks source link

Add proxy capabilities and move conection lifetime to api configuration #49

Closed redmars27 closed 5 years ago

redmars27 commented 5 years ago

I dont think that many people will need this, as most of the usage will be on the internet already, but adding the functionality was not that big and if someone needs to access from behind a corporate firewall this will allow it easilly. If I want to check something from the office, I will need it anyway.

Also I moved the 1 minute lifetime to the configuration and remove the hardcoded one, just in case we need to change to another value in the future.

avivbiton commented 5 years ago

Thanks, I will merge this, but I want to refactor some of the code.
I feel like ApiConfiguration is getting a bit crowded and I'm thinking about creating another class to handle (usually) static configuration for things like that and maybe caching and other settings that may not change or doesn't change often.
Configurations like region and locale can change frequently depending on how the library is used.

redmars27 commented 5 years ago

Sure, let me know if I can help or if you want someone to discuss possible options.