avk959 / LGenerics

Generic algorithms and data structures for Lazarus/Free Pascal
Apache License 2.0
113 stars 16 forks source link

avoid too generic identifiers to avoid possible clash with big apps #10

Closed Alexey-T closed 1 year ago

Alexey-T commented 1 year ago
const
  DEFAULT_DEPTH    = TJsonReader.DEF_DEPTH;
  DEFAULT_BUF_SIZE = TJsonReader.DEF_BUF_SIZE;
Alexey-T commented 1 year ago

e.g. add some prefix to them.

avk959 commented 1 year ago

Could you please clarify what you are talking about?

Alexey-T commented 1 year ago

big app (many units) may have var with name DEFAULT_BUF_SIZE. so better to rename your const to e.g. lgDefaultBufSize.

avk959 commented 1 year ago

These constants were already part of the TJtdEntity class before I saw your message.

Alexey-T commented 1 year ago

better to rename these 2 consts. but you are the boss.