avk959 / LGenerics

Generic algorithms and data structures for Lazarus/Free Pascal
Apache License 2.0
111 stars 16 forks source link

too generic names #7

Closed Alexey-T closed 2 years ago

Alexey-T commented 2 years ago

resourcestring SEInvalidJsonFile = '"%s" is not a valid JSON configuration file'; SECouldNotOpenKey = 'Could not open key "%s"';

They may conflict with user-defined names

avk959 commented 2 years ago

To be honest, the mechanism of such a conflict is not entirely clear, could you give an example? However, this is not important, I will agree to any of your suggestions.

Alexey-T commented 2 years ago

These are resource strings. They will be saved to app i18n files. If user makes his own resource strings named the same , we have conflict in i18n

avk959 commented 2 years ago

So what are you suggesting?

Alexey-T commented 2 years ago

resourcestring SlgEInvalidJsonFile = '"%s" is not a valid JSON configuration file'; SlgECouldNotOpenKey = 'Could not open key "%s"';

avk959 commented 2 years ago

Done, 622e7c88

Alexey-T commented 2 years ago

Thanks