avlee / npapi-sdk

Automatically exported from code.google.com/p/npapi-sdk
0 stars 0 forks source link

OpenGL.h include in npapi.h on mac is problematic for some users #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In the chromium project, the fact that OpenGL.h is included in npapi.h on mac 
has proven troublesome.  Including this header pulls in a large number of 
#defines, typedefs, and global symbols.  npapi.h is included in fairly common 
headers in the chromium project via some IPC-related headers to serialize types 
and we've accumulated various hacks to work around collisions such as: 
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/browser/renderer_host
/render_message_filter.cc&exact_package=chromium&ct=rc&cd=37&q=npapi.h&sq=&l=108
5

This include exists to support the NPDrawingModelOpenGL rendering model, which 
as far as I know has never been supported and likely never will be supported by 
any browser.

Original issue reported on code.google.com by jamesr@chromium.org on 8 Jan 2013 at 8:41

GoogleCodeExporter commented 9 years ago
https://codereview.appspot.com/7066056

Original comment by jamesr@chromium.org on 8 Jan 2013 at 8:49

GoogleCodeExporter commented 9 years ago
LGTM with nit.

Josh, what do you think? The other option I can see would be to pull the OpenGL 
code out entirely, but that seems more potentially disruptive so I though we 
should start with this.

Original comment by stuart.morgan on 9 Jan 2013 at 5:40

GoogleCodeExporter commented 9 years ago
I'm fine with this approach. I'd also be fine with just removing the model but 
I don't think any of us want to spend time dealing with any potential fallout.

Original comment by josh....@gmail.com on 10 Jan 2013 at 12:42

GoogleCodeExporter commented 9 years ago
Committed as r23.

Original comment by stuart.morgan on 14 Jan 2013 at 9:47