search

avli / clojureVSCode

Clojure support for Visual Studio Code
https://avli.github.io/clojureVSCode/
MIT License
204 stars 34 forks source link

Default host input box to 'localhost'. #36

Closed mhansen closed 7 years ago

mhansen commented 7 years ago

Fixes #35

avli commented 7 years ago

Hi @mhansen

Thank you for the pull request.

Have you tested this change on a Windows platform? I used the "localhost" value as the default one but later I found it doesn't work on Windows, so it was disabled in order to avoid possible issues.

fasfsfgs commented 7 years ago

I did #38 to solve the same issue. I used 127.0.0.1 tho. And I did some refactoring for better error handling. Previously we didn't have any error message on some connection failures.

Sorry I didn't see this PR before. =/

avli commented 7 years ago

@fasfsfgs the same question for you – have you tested your changes on Windows? I believe that the issue that stopped me from adding the default host previously was the VSCode Windows version's one. I'm wondering if they fixed it?

fasfsfgs commented 7 years ago

@avli I don't have windows to test against. Only osx here. =/

avli commented 7 years ago

@mhansen do you?

mhansen commented 7 years ago

No, I don't have a windows box

On Tue, 11 Jul 2017 at 15:29 Andrey Lisin notifications@github.com wrote:

@mhansen https://github.com/mhansen do you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/avli/clojureVSCode/pull/36#issuecomment-314327060, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGcOVPxRw3eFHV3lmNMsynftI2QTHdjks5sMwgigaJpZM4OR99A .

avli commented 7 years ago

All right, I'm going to check both pull requests on Windows and then merge to the upstream if everything is fine.