search

avli / clojureVSCode

Clojure support for Visual Studio Code
https://avli.github.io/clojureVSCode/
MIT License
204 stars 34 forks source link

Add a channel for nREPL output to the Output Window #92

Closed marcomorain closed 6 years ago

marcomorain commented 6 years ago

Add a channel to show nREPL output to the user. This channel will be used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code is printed to the nREPL output channel, and the channel is brough to the front.

Fixes #52 Fixed #69

Also fixes a bug where the 'Starting nREPL' status message would never clear if the repl failed to start.

screen shot 2018-02-06 at 15 39 09
marcomorain commented 6 years ago

Hi @avli - do you have some time to review this PR? It's really helped me debug nREPL issues.

avli commented 6 years ago

@marcomorain thank you very much for your contribution – I know this feature is a long-awaited by some users.

marcomorain commented 6 years ago

You are very welcome!