avluis / Hentoid

Doujinshi Android App
https://discord.gg/QEZ3qk9
Apache License 2.0
1.08k stars 85 forks source link

[Request] Remove analytics or give option to disable analytics #92

Closed cukoid closed 8 years ago

cukoid commented 8 years ago

^

avluis commented 8 years ago

Any particular reason why? We sort of need the data since the community is pretty quiet about things (minus a few here and there) - I still don't have my testers. Also, what happened to that template there, what is this: ^?

wightwulf1944 commented 8 years ago

I also would like to know the specific concern here. Can you tell us about the motivation behind this?

cukoid commented 8 years ago

Because el' Google doesn't need to know when I'm fappin' to Hentai.

Also, if you guys ever tried to get into the F-Droid repos, they would not approve it mostly because of Google Analytics or they would mark it as an antifeature.

Also, the " ^ " is pointing at the title, as I thought this needed no explaining.

Anyways, I appreciate the hard work put on this application.

avluis commented 8 years ago

LOL! Man, this is too funny - Google does not know nor care about when you fappin'. LOL.

The reason I mentioned the " ^ " is because this repo has templates that need to be filled out before an issue is submitted, which you simply ignored.

Give me a proper reason why Google Analytics should not be on this application, and not a big brother is watching sort of reason.

cukoid commented 8 years ago

Because you should use a Free and Open Sauce analytics software like Piwik instead. Or give a toggle in settings to disable it.

avluis commented 8 years ago

Hold on - so you don't have no problem with a bit of data being collected, as long as it is not Google?

cukoid commented 8 years ago

Yes, or if you give the option to disable tracking.

avluis commented 8 years ago

If I follow this request, I would implement Piwik, leaving Google Analytics alone while giving the user an option to choose between tracking.

cukoid commented 8 years ago

I guess that's fine, but I don't understand why you can't have a "no tracking" option, instead of choosing between GA and Piwik.

Edit: I sound like I'm giving mixed messages.

wightwulf1944 commented 8 years ago

Hi,

Regarding personally identifiable data, Google Analytics does not send any of the sort. It is literally impossible to identify who is doing what at any time with the data that is collected by Analytics. We opted to choose Google Analytics because it is a service that is under careful scrutiny of many people. Because of that we can be sure that nothing personal is being collected and no rights are being infringed

If we were to use a different Analytics service however we would have to take action to ensure that all data being collected is safe, and does not infringe privacy, and local laws.

TL;DR: We're sure that Google Analytics is safe, we're not so sure about other services. For more information on this, you may read Google Analytics' terms of service found here.

Regarding your concern about F-Droid's inclusion policy. Unfortunately, Hentoid violates almost every item in the list. As funny as this may seem, I don't mean this to be a joke! Particularly "trademarks must not be infringed, and any other legal requirements must be adhered to". Though Hentoid does not host any copyrighted works it can be considered as a tool that enables users to download such material.

As such, we no longer hope to have Hentoid available in F-Droid's repo: F-Droid Inclusion Policy.

And finally, since this is an open source project you're more than welcome to walk through the code and see what kind of information exactly is being collected.

wightwulf1944 commented 8 years ago

Oh no, we find these kinds of discussion to be insightful. And I just want to emphasize that we are not educated in law, so we'd rather take the safe route with google analytics and not be sued for information we didn't know we were collecting.

we'll try to contact you when development resumes and we have things we need testing with. Please don't hesitate to contact us through our fakkudroid blog, google+ community, or file an issue here if you have any further concerns. And please make github issues detailed so that we can resolve your concern in a timely manner.

cukoid commented 8 years ago

Um, there are manga readers on F-Droid, so I don't understand how your app would violate F-Droid's terms if those apps don't.

avluis commented 8 years ago

@cukoid It's OK - every concern is a valid one. At the moment, any tester I need does not need to be knowledgeable with programming at all! I send you a build to test, and if you don't already know, I walk you through the steps required in order to get it installed.

Anyways, addressing a few more points, particularly regarding Piwik: The self hosting is good (I would need to run a website for it to work), but bad at the same time, if that website is down, then so is tracking. The self hosting is also good because we can control the data, but also bad because I then need to put time into making sure that this data is not compromised, misused and otherwise taken care of properly.

With Google Analytics, I foraged every possible setting to make sure no user identifiable data is ever tracked, this is also against their terms of use as @wightwulf1944 mentioned above. The main reason for Google Analytics is one simple reason: We know were the app needs work, where it crashes, on what Android version it crashes on and what crashes.

I'm sorry I came off a bit strong, but this data is invaluable to a small project like this, I hope you can understand this.

cukoid commented 8 years ago

https://f-droid.org/repository/browse/?fdid=eu.kanade.tachiyomi https://f-droid.org/repository/browse/?fdid=ar.rulosoft.mimanganu

(Manga apps on F-Droid)

avluis commented 8 years ago

@cukoid I've been aware of those applications being on that repository - believe it or not, it's still a grey area - even worse when dealing with copyrighted doujinshi works, which Hentoid facilitates access to.

I believe F-Droid goes by a sweep process and/or community flagging of infringing applications - so you may see a few apps today that are on there, but they may get removed at any time if their community deems it so.

wightwulf1944 commented 8 years ago

I might contact the developers of those apps to see what they've done regarding the policy.

Also, in-app updaters are also not allowed.

avluis commented 8 years ago

@wightwulf1944 I forgot to mention that part as well - if we want the updater to stay and be on the F-Droid repo, it won't happen - even if we can somehow stay on there as soon as they realize what Hentoid gives access to.

@cukoid If you ever get the chance, if you read plenty of manga, give Manga Rock a try - not free, nor open source, but I believe it is a lot better than 'most' free options out there.

cukoid commented 8 years ago

avluis, I have it, just not installed atm because I'm "behind with the times" on what manga is good. Lol. I'm going to install it again. (Off topic I know)

I wonder why that app is still on Google Play.

avluis commented 8 years ago

Yeah, I know it's a bit off topic - who cares, LOL! @wightwulf1944 Please don't kill me.

@cukoid When you do, opt in to the beta version of their app, it is much better. Once you do, visit the 'All Manga' tab, it should sort by popularity by default.

cukoid commented 8 years ago

@avluis where do i apply to become a tester, the github issue for it is locked

avluis commented 8 years ago

@cukoid You would message me directly - but since I know you are interested, I can add you right now. Is that the case?

cukoid commented 8 years ago

Yes, that is the case.

I did submit Hentoid to the F-Droid submission queue subforum, but the problem with it at this point is that it "uses play services". Not sure if you cared about getting it on F-Droid or not (I personally think it would increase users, maybe) but I thought I would mention that regardless.

avluis commented 8 years ago

Correct - anything that uses private sources cannot be added to the F-Droid repo. I have added you to the list of testers - can you provide me some info about the devices you have at your disposal and what Android version are they running.

cukoid commented 8 years ago

Moto G 2014 (CM13 - Android 6.0.1) Nexus 7 2013 (Android 6.0.1) Shield Portable (Android 4.4.2)

avluis commented 8 years ago

@cukoid What was the last official update for that Moto G that you ended up installing CM? How does it run there, and do you have GApps installed?

cukoid commented 8 years ago

@avluis I think it was 5.0.1. But now there's an official 6.0.1. CM13 runs fine most of the time. When the phone's CPU gets busy, it bogs it down a lot, but that's the same with the official firmware. And yes, I have Gapps installed.

mffe commented 8 years ago

@avluis Can you please add an additional branch that follows the F-Droid inclusion policy? (i.e. no play services and auto-updater) There's no need to remove those things from the official builds if you want to be on F-Droid.

avluis commented 8 years ago

@mffe Who says we want to be on F-Droid?

mffe commented 8 years ago

@avluis I know it's your decision to add a F-Droid branch to this repository (which would merely involve removing some lines), but you're missing out on a lot of technically inclined users who may improve this open source app.

avluis commented 8 years ago

@mffe What build [release] of Hentoid do you have installed?

mffe commented 8 years ago

@avluis I don't have Hentoid installed because of this issue.

Nonononoki commented 5 years ago

@avluis Sorry for reviving old issue, but do you mind if I fork this project and try to get it on F-Droid?

wightwulf1944 commented 5 years ago

@Nonononoki no problem man. But remember that F-Droid policy states that apps that allow access to illegal content is not allowed (more on that here). I would recommend using a new email for your f-droid account in case it gets banned.

If you need guidance on locating stuff in the code, talk to us on discord

Thewisem commented 3 years ago

Its forked and is on fdroid. Nice